Add support for esp32 #3
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: okhsunrog/can_wizard#3
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "esp32_support"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I've added support for the project to be compiled and used on a 'bare' ESP32.
The project now compiles for both 'ESP32' and 'ESP32-C3'.
@mrfussion I use a fork of console component: https://github.com/okhsunrog/console_esp-idf
@mrfussion could you please update console submodule to use this commit? Also you could migrate from using deprecated functions as the warnings suggest if you wish. After that I'd be glad to merge this PR
@okhsunrog I quickly looked over the deprecated functions and tried to make the change, but for some reason it didn't work. It's not a problem for me to fix this, it will just take me a bit longer. Please be patient :)
I can send this over to draft if you like it.
Not a problem at all! Just tag me when the PR is ready for review. After the review, you'll test it on esp32, I'll test on esp32c3 and if everything works for both chips I'll merge it
@okhsunrog I believe the warnings are library-specific and can't be resolved. Given this, I don't think there's anything more we can do.
I'm going to add the complete build log to this pull request for safekeeping:
@mrfussion oh, I guess I just need to fix it in console component. thanks, I think it can be merged now
Be careful when changing calls to functions in the console, because although it indicates which is the replacement function in the library, they are not implemented (at least in the headers you are using).
@mrfussion I fixed the warnings in the latest commit